37f45eb621b04a1286ac1667b7474111e6e0b4ce

Author
Patryk Małek <malekpatryk@gmail.com>
Committer
Patryk Małek <malekpatryk@gmail.com>
Date

Message

Making variables local in jira plugin

Diff

 1diff --git a/plugins/jira/jira.plugin.zsh b/plugins/jira/jira.plugin.zsh
 2index 769bf23670ae0f1f9e66bae029f084dae10e8e75..7839e2a80c3f3a980f160e08c8649cf2e2d193ea 100644
 3--- a/plugins/jira/jira.plugin.zsh
 4+++ b/plugins/jira/jira.plugin.zsh
 5@@ -19,6 +19,7 @@ open_jira_issue () {
 6     open_cmd='xdg-open'
 7   fi
 8 
 9+  local jira_url
10   if [ -f .jira-url ]; then
11     jira_url=$(cat .jira-url)
12   elif [ -f ~/.jira-url ]; then
13@@ -30,6 +31,7 @@ open_jira_issue () {
14     return 1
15   fi
16 
17+  local jira_prefix
18   if [ -f .jira-prefix ]; then
19     jira_prefix=$(cat .jira-prefix)
20   elif [ -f ~/.jira-prefix ]; then
21@@ -45,7 +47,7 @@ open_jira_issue () {
22     $open_cmd "${jira_url}/secure/CreateIssue!default.jspa"
23   elif [[ "$1" = "assigned" || "$1" = "reported" ]]; then
24     jira_query $@
25-  else 
26+  else
27     local addcomment=''
28     if [[ "$2" == "m" ]]; then
29       addcomment="#add-comment"
30@@ -53,11 +55,11 @@ open_jira_issue () {
31     else
32       echo "Opening issue #$1"
33     fi
34-    
35+
36     if [[ "$JIRA_RAPID_BOARD" == "true" ]]; then
37-      $open_cmd  "$jira_url/issues/$jira_prefix$1$addcomment"
38+      $open_cmd "$jira_url/issues/$jira_prefix$1$addcomment"
39     else
40-      $open_cmd  "$jira_url/browse/$jira_prefix$1$addcomment"
41+      $open_cmd "$jira_url/browse/$jira_prefix$1$addcomment"
42     fi
43   fi
44 }
45@@ -76,7 +78,11 @@ jira_name () {
46 }
47 
48 jira_query () {
49+  local jira_name
50+  local verb
51   verb="$1"
52+  local lookup
53+  local preposition
54   if [[ "${verb}" = "reported" ]]; then
55     lookup=reporter
56     preposition=by