fix(tools/check_for_upgrade): Don't source profile
Reverts #2296, but mostly #1883.
There is no need to source ~/.profile when this script is read. oh-my-zsh writes no configuration data in ~/.profile.
If the user wishes to use data within ~/.profile, then they should source it in another place.
Fixes #2315
Diff
1diff --git a/tools/check_for_upgrade.sh b/tools/check_for_upgrade.sh
2index 4a0803210e85a57e1d24f13229521a2d4caa0f2c..b2b356e0cb957a0701b29732be1a2a43cd760e12 100644
3--- a/tools/check_for_upgrade.sh
4+++ b/tools/check_for_upgrade.sh
5@@ -22,8 +22,6 @@ if [[ -z "$epoch_target" ]]; then
6 epoch_target=13
7 fi
8 9-[ -f ~/.profile ] && source ~/.profile
10-
11 # Cancel upgrade if the current user doesn't have write permissions for the
12 # oh-my-zsh directory.
13 [[ -w "$ZSH" ]] || return 0