fix(tools/check_for_upgrade): Don't source profile
Reverts #2296, but mostly #1883.
There is no need to source ~/.profile when this script is read. oh-my-zsh writes no configuration data in ~/.profile.
If the user wishes to use data within ~/.profile, then they should source it in another place.
Fixes #2315
Diff
1diff --git a/tools/check_for_upgrade.sh b/tools/check_for_upgrade.sh
2index 5c8ce3a5052135ef250d2d17a2d7164986a3ddf1..c5fd0cce15e6e1b841454450fc662dc6af90e971 100644
3--- a/tools/check_for_upgrade.sh
4+++ b/tools/check_for_upgrade.sh
5@@ -20,8 +20,6 @@ if [[ -z "$epoch_target" ]]; then
6 epoch_target=13
7 fi
8 9-[ -f ~/.profile ] && source ~/.profile
10-
11 if [ -f ~/.zsh-update ]
12 then
13 . ~/.zsh-update