aab235f6121a93b81a425d522a0c7f2aaac946bd

Author
Brandon Philips <brandon@ifup.org>
Committer
Brandon Philips <brandon@ifup.org>
Date

Message

functions: fix title() to not match any $TERM

On my linux virtual terminals, where TERM="linux", I was getting
annoying output that was messing up my prompt.

It turns out the title function was always matching on the elif
statement for xterm/rxvt no matter what and the linux vt doesn't know
what to do with the title special control sequence and thus was printing
out garbage.

Through experimentation I figured out that the || inside of the [[ ]]
did not work:

export TERM=linux
$ if [[ $TERM =~ "^xterm" || $TERM == "rxvt" ]]; then echo $TERM; fi
linux

$ if [[ $TERM =~ "^xterm" ]] || [[ $TERM == "rxvt" ]]; then echo $TERM; fi

Signed-off-by: Brandon Philips <brandon@ifup.org>

openSUSE running zsh 4.3.10

Diff

 1diff --git a/lib/functions.zsh b/lib/functions.zsh
 2index 561586cba657cb274f76b6a7a87743e154f006e4..e494f1f4d3153b753da1b0fc2f3b87be843931b2 100644
 3--- a/lib/functions.zsh
 4+++ b/lib/functions.zsh
 5@@ -5,7 +5,7 @@ function title {
 6     print -nR $'\033k'$1$'\033'\\\
 7 
 8     print -nR $'\033]0;'$2$'\a'
 9-  elif [[ $TERM =~ "^xterm" || $TERM == "rxvt" ]]; then
10+  elif [[ ($TERM =~ "^xterm") ]] || [[ ($TERM == "rxvt") ]]; then
11     # Use this one instead for XTerms:
12     print -nR $'\033]0;'$*$'\a'
13   fi