accdcb2f1c3cca40527fef1fe4ab2d39eb6cf897

Author
Janosch Knack <janosch.knack@gmail.com>
Committer
Robby Russell <robby@planetargon.com>
Date

Message

improved maven plugin (#6298)

* added some apache maven plugins

added arguments
added longversion of arguments

* SC2006 shellcheck
see https://github.com/koalaman/shellcheck/wiki/SC2006

* SC2068 shellcheck
see https://github.com/koalaman/shellcheck/wiki/SC2068

* SC2086 shellcheck

see https://github.com/koalaman/shellcheck/wiki/SC2086

* shellcheck is not always right ;)

Diff

This diff is truncated to protect this page.

 1diff --git a/plugins/mvn/mvn.plugin.zsh b/plugins/mvn/mvn.plugin.zsh
 2index c5a7faa0f6b00ac9fe766b252bb408e80d05d97b..f1e4d3ee0e2cae53018e506c3b7fb4c5d08c0b6c 100644
 3--- a/plugins/mvn/mvn.plugin.zsh
 4+++ b/plugins/mvn/mvn.plugin.zsh
 5@@ -1,24 +1,24 @@
 6 # mvn-color based on https://gist.github.com/1027800
 7-BOLD=`tput bold`
 8-UNDERLINE_ON=`tput smul`
 9-UNDERLINE_OFF=`tput rmul`
10-TEXT_BLACK=`tput setaf 0`
11-TEXT_RED=`tput setaf 1`
12-TEXT_GREEN=`tput setaf 2`
13-TEXT_YELLOW=`tput setaf 3`
14-TEXT_BLUE=`tput setaf 4`
15-TEXT_MAGENTA=`tput setaf 5`
16-TEXT_CYAN=`tput setaf 6`
17-TEXT_WHITE=`tput setaf 7`
18-BACKGROUND_BLACK=`tput setab 0`
19-BACKGROUND_RED=`tput setab 1`
20-BACKGROUND_GREEN=`tput setab 2`
21-BACKGROUND_YELLOW=`tput setab 3`
22-BACKGROUND_BLUE=`tput setab 4`
23-BACKGROUND_MAGENTA=`tput setab 5`
24-BACKGROUND_CYAN=`tput setab 6`
25-BACKGROUND_WHITE=`tput setab 7`
26-RESET_FORMATTING=`tput sgr0`
27+BOLD=$(tput bold)
28+UNDERLINE_ON=$(tput smul)
29+UNDERLINE_OFF=$(tput rmul)
30+TEXT_BLACK=$(tput setaf 0)
31+TEXT_RED=$(tput setaf 1)
32+TEXT_GREEN=$(tput setaf 2)
33+TEXT_YELLOW=$(tput setaf 3)
34+TEXT_BLUE=$(tput setaf 4)
35+TEXT_MAGENTA=$(tput setaf 5)
36+TEXT_CYAN=$(tput setaf 6)
37+TEXT_WHITE=$(tput setaf 7)
38+BACKGROUND_BLACK=$(tput setab 0)
39+BACKGROUND_RED=$(tput setab 1)
40+BACKGROUND_GREEN=$(tput setab 2)
41+BACKGROUND_YELLOW=$(tput setab 3)
42+BACKGROUND_BLUE=$(tput setab 4)
43+BACKGROUND_MAGENTA=$(tput setab 5)
44+BACKGROUND_CYAN=$(tput setab 6)
45+BACKGROUND_WHITE=$(tput setab 7)
46+RESET_FORMATTING=$(tput sgr0)
47 
48 
49 # Wrapper function for Maven's mvn command.
50@@ -26,15 +26,15 @@ mvn-color() {
51   (
52   # Filter mvn output using sed. Before filtering set the locale to C, so invalid characters won't break some sed implementations
53   unset LANG
54-  LC_CTYPE=C mvn $@ | sed -e "s/\(\[INFO\]\)\(.*\)/${TEXT_BLUE}${BOLD}\1${RESET_FORMATTING}\2/g" \
55+  LC_CTYPE=C mvn "$@" | sed -e "s/\(\[INFO\]\)\(.*\)/${TEXT_BLUE}${BOLD}\1${RESET_FORMATTING}\2/g" \
56                -e "s/\(\[INFO\]\ BUILD SUCCESSFUL\)/${BOLD}${TEXT_GREEN}\1${RESET_FORMATTING}/g" \
57                -e "s/\(\[WARNING\]\)\(.*\)/${BOLD}${TEXT_YELLOW}\1${RESET_FORMATTING}\2/g" \
58                -e "s/\(\[ERROR\]\)\(.*\)/${BOLD}${TEXT_RED}\1${RESET_FORMATTING}\2/g" \