ee4910e3b36dc5556cad567c3760ee500297cc8e

Author
Marc Cornellà <hello@mcornella.com>
Committer
Marc Cornellà <hello@mcornella.com>
Date

Message

fix: show full hyperlinks in Konsole (#10964)

Fixes #10964

Diff

 1diff --git a/tools/install.sh b/tools/install.sh
 2index bc372305082cd0d22d35b06bb7af000bac6841c5..fb6973dbc85ce9e78945e28879a99d82058c6bb0 100755
 3--- a/tools/install.sh
 4+++ b/tools/install.sh
 5@@ -156,11 +156,17 @@ supports_hyperlinks() {
 6     return 0
 7   fi
 8 
 9-  # Windows Terminal or Konsole also support hyperlinks
10-  if [ -n "$WT_SESSION" ] || [ -n "$KONSOLE_VERSION" ]; then
11+  # Windows Terminal also supports hyperlinks
12+  if [ -n "$WT_SESSION" ]; then
13     return 0
14   fi
15 
16+  # Konsole supports hyperlinks, but it's an opt-in setting that can't be detected
17+  # https://github.com/ohmyzsh/ohmyzsh/issues/10964
18+  # if [ -n "$KONSOLE_VERSION" ]; then
19+  #   return 0
20+  # fi
21+
22   return 1
23 }
24 
25diff --git a/tools/upgrade.sh b/tools/upgrade.sh
26index 2f3b4dae337a022c915ed8cae58a464f33843e70..596a593025cfa3a57e0a66b40829823a965ae439 100755
27--- a/tools/upgrade.sh
28+++ b/tools/upgrade.sh
29@@ -78,11 +78,17 @@ supports_hyperlinks() {
30     return 0
31   fi
32 
33-  # Windows Terminal or Konsole also support hyperlinks
34-  if [ -n "$WT_SESSION" ] || [ -n "$KONSOLE_VERSION" ]; then
35+  # Windows Terminal also supports hyperlinks
36+  if [ -n "$WT_SESSION" ]; then
37     return 0
38   fi
39 
40+  # Konsole supports hyperlinks, but it's an opt-in setting that can't be detected
41+  # https://github.com/ohmyzsh/ohmyzsh/issues/10964
42+  # if [ -n "$KONSOLE_VERSION" ]; then
43+  #   return 0
44+  # fi
45+
46   return 1
47 }
48