06b7dce565500e7e1cfdd0803239dff430101b8b

Author
フィルターペーパー <76888457+filterpaper@users.noreply.github.com>
Committer
GitHub <noreply@github.com>
Date

Message

Refactor LED Breathing effect with runner (#24540)

Diff

 1diff --git a/quantum/led_matrix/animations/breathing_anim.h b/quantum/led_matrix/animations/breathing_anim.h
 2index 0bd4cb0cc38899dbfb84612051228290a728c138..3d1b0d95d2186dc6e34e14da144cc28b5ca2bf08 100644
 3--- a/quantum/led_matrix/animations/breathing_anim.h
 4+++ b/quantum/led_matrix/animations/breathing_anim.h
 5@@ -2,17 +2,12 @@
 6 LED_MATRIX_EFFECT(BREATHING)
 7 #    ifdef LED_MATRIX_CUSTOM_EFFECT_IMPLS
 8 
 9-bool BREATHING(effect_params_t* params) {
10-    LED_MATRIX_USE_LIMITS(led_min, led_max);
11+static uint8_t BREATHING_math(uint8_t val, uint8_t i, uint8_t time) {
12+    return scale8(abs8(sin8(time / 2) - 128) * 2, val);
13+}
14 
15-    uint8_t  val  = led_matrix_eeconfig.val;
16-    uint16_t time = scale16by8(g_led_timer, led_matrix_eeconfig.speed / 8);
17-    val           = scale8(abs8(sin8(time) - 128) * 2, val);
18-    for (uint8_t i = led_min; i < led_max; i++) {
19-        LED_MATRIX_TEST_LED_FLAGS();
20-        led_matrix_set_value(i, val);
21-    }
22-    return led_matrix_check_finished_leds(led_max);
23+bool BREATHING(effect_params_t* params) {
24+    return effect_runner_i(params, &BREATHING_math);
25 }
26 
27 #    endif // LED_MATRIX_CUSTOM_EFFECT_IMPLS