530e0447621c8a23dbd2bf22137b1e90bdc61989

Author
Joel Challis <git@zvecr.com>
Committer
GitHub <noreply@github.com>
Date

Message

Update PR Checklist for 'via' keymaps (#24330)

Diff

This diff is truncated to protect this page.

 1diff --git a/docs/pr_checklist.md b/docs/pr_checklist.md
 2index d95d459b06933caa21d295781d77e881bf8443eb..268e3b1b116a01d2d74db212f4502a6d4de8f5c6 100644
 3--- a/docs/pr_checklist.md
 4+++ b/docs/pr_checklist.md
 5@@ -44,12 +44,14 @@ If there are any inconsistencies with these recommendations, you're best off [cr
 6 Note that personal keymap submissions will no longer be accepted. This section applies to manufacturer-supported keymaps. Please see this [issue](https://github.com/qmk/qmk_firmware/issues/22724) for more information.
 7 :::
 8 
 9-- PRs for vendor specific keymaps will be permitted. The naming convention for these should be `default_${vendor}`, `via_${vendor}` i.e. `via_clueboard`.
10-    - vendor specific keymaps do not necessarily need to be "vanilla" and can be more richly featured than `default` or `via` stock keymaps.
11+- PRs for vendor specific keymaps will be permitted. The naming convention for these should be `default_${vendor}` i.e. `default_clueboard`.
12+    - vendor specific keymaps do not necessarily need to be "vanilla" and can be more richly featured than `default` stock keymaps.
13 - `#include QMK_KEYBOARD_H` preferred to including specific board files
14 - prefer layer enums to #defines
15 - custom keycode enums must have first entry = `QK_USER`
16 - some care with spacing (e.g., alignment on commas or first char of keycodes) makes for a much nicer-looking keymap. Spaces are preferred to tabs
17+- keymaps should not enable VIA
18+    - keymaps targeting VIA support should be submitted to the [VIA QMK Userspace](https://github.com/the-via/qmk_userspace_via) repository
19 
20 ## Keyboard PRs
21 
22@@ -136,12 +138,12 @@ https://github.com/qmk/qmk_firmware/pulls?q=is%3Apr+is%3Aclosed+label%3Akeyboard
23 - `keymaps/default/keymap.c`
24     - `QMKBEST`/`QMKURL` example macros removed