73b376a88151d03d43e0eca8242faa4bad199ac0
- Author
- Stefan Kerkmann <karlk90@pm.me>
- Committer
- GitHub <noreply@github.com>
- Date
Message
[Chore] Remove stray mod tap interrupt defines and per key functions (#20347) * Remove stray defines and per key functions * Remove defunct get_ignore_mod_tap_interrupt declaration
Diff
This diff is truncated to protect this page.
1diff --git a/docs/zh-cn/mod_tap.md b/docs/zh-cn/mod_tap.md
2index 5bf18a152787dce8fd721f4f95c5c48f95f092c2..9dc59bfb79fdbddd550b760e3b02ce92cffe6bb7 100644
3--- a/docs/zh-cn/mod_tap.md
4+++ b/docs/zh-cn/mod_tap.md
5@@ -117,8 +117,6 @@ bool process_record_user(uint16_t keycode, keyrecord_t *record) {
6 }
7 ```
8
9-在数字及字母键上使用Mod-Tap时推荐启用 `IGNORE_MOD_TAP_INTERRUPT`，以避免在快速按下下一个键时保持功能优先级。参见[忽略Mod Tap中断](zh-cn/tap_hold.md#ignore-mod-tap-interrupt)。
10-
11 ### 同时改变点击和按住功能
12
13 最后一个例子通过 `LT(0,KC_NO)` 实现了点击复制，按住粘贴的功能：
14diff --git a/keyboards/crkbd/keymaps/cameronjlarsen/config.h b/keyboards/crkbd/keymaps/cameronjlarsen/config.h
15index f0f4fb14db41648f395653c6cd3c297c6b67da4f..1d83214a7779a631b945d2db74ccf2b9d1032db0 100644
16--- a/keyboards/crkbd/keymaps/cameronjlarsen/config.h
17+++ b/keyboards/crkbd/keymaps/cameronjlarsen/config.h
18@@ -25,7 +25,6 @@
19 #define TAPPING_FORCE_HOLD
20 #define TAPPING_TERM 135
21
22-#define IGNORE_MOD_TAP_INTERRUPT
23 #define CAPS_WORD_IDLE_TIMEOUT 5000 // Turn off Caps Word after 5 seconds.
24
25 #ifdef RGBLIGHT_ENABLE
26diff --git a/keyboards/handwired/stef9998/split_5x7/keymaps/stef9998/keymap.c b/keyboards/handwired/stef9998/split_5x7/keymaps/stef9998/keymap.c
27index 5b74c3567e3599ed6d3cdd270ef34223374fb58a..833a245c5437f5144e16f9184dbd9bcfb8ee7384 100644
28--- a/keyboards/handwired/stef9998/split_5x7/keymaps/stef9998/keymap.c
29+++ b/keyboards/handwired/stef9998/split_5x7/keymaps/stef9998/keymap.c
30@@ -39,20 +39,20 @@ enum custom_keycodes {
31 // Shortcut to make keymap more readable
32 #define KC_FN MO(_FN)
33
34-bool get_ignore_mod_tap_interrupt(uint16_t keycode, keyrecord_t *record) {
35+bool get_hold_on_other_key_press(uint16_t keycode, keyrecord_t *record) {
36 switch (keycode) {
37 case SC_LSPO:
38 // Do not force the mod-tap key press to be handled as a modifier
39 // if any other key was pressed while the mod-tap key is held down.
40- return false;
41+ return true;
42 // case MT(MOD_LSFT,KC_9):
43 // return false;
44 case SC_RSPC:
45- return false;
46+ return true;
47 default:
48 // Force the mod-tap key press to be handled as a modifier if any
49 // other key was pressed while the mod-tap key is held down.
50- return true;
51+ return false;
52 }
53 }
54
55@@ -185,4 +185,4 @@ _______ ,_______ ,RALT_T(KC_S),LCTL_T(KC_D),LSFT_T(KC_F),LT(_SYM,KC_G),_______ ,
56 _______ ,_______ ,_______ ,_______ ,_______ ,_______ , _______ ,_______ ,_______ ,_______ ,_______ ,_______
57diff --git a/keyboards/karn/keymaps/colemak/keymap.c b/keyboards/karn/keymaps/colemak/keymap.c
58index dbe78c0dada5604bd58e474599375527d2c31954..63b34f785e5eb215c48539a196348dc77ce1eb52 100644
59--- a/keyboards/karn/keymaps/colemak/keymap.c
60+++ b/keyboards/karn/keymaps/colemak/keymap.c
61@@ -27,37 +27,6 @@ bool get_hold_on_other_key_press(uint16_t keycode, keyrecord_t *record) {
62 }
63 }
64
65-bool get_ignore_mod_tap_interrupt(uint16_t keycode, keyrecord_t *record) {
66- switch (keycode) {
67- case CTL_T(KC_X):
68- return true;
69- case ALT_T(KC_C):
70- return true;
71- case CMD_T(KC_V):
72- return true;
73- case CMD_T(KC_M):
74- return true;
75- case ALT_T(KC_COMM):
76- return true;
77- case CTL_T(KC_DOT):
78- return true;
79- case KC_X:
80- return true;
81- case KC_C:
82- return true;
83- case KC_V:
84- return true;
85- case KC_M:
86- return true;
87- case KC_COMM:
88- return true;
89- case KC_DOT:
90- return true;
91- default:
92- return false;
93- }
94-}
95-
96 const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
97
98
99@@ -93,4 +62,3 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
100 _______, _______, _______, _______, _______, _______
101 )
102 };
103-
104diff --git a/keyboards/splitkb/aurora/sweep/keymaps/default/keymap.json b/keyboards/splitkb/aurora/sweep/keymaps/default/keymap.json
105index b62202d2b4c0f6f368ad760bd0dc9109f03d1867..ade21d5ece15c173732c08aa34c737c042b5578d 100644
106--- a/keyboards/splitkb/aurora/sweep/keymaps/default/keymap.json
107+++ b/keyboards/splitkb/aurora/sweep/keymaps/default/keymap.json
108@@ -79,7 +79,6 @@
109 "tapping": {
110 "term": 200,
111 "permissive_hold": true,
112- "ignore_mod_tap_interrupt": true,
113 "force_hold": true
114 }
115 }
116diff --git a/keyboards/splitkb/kyria/keymaps/cameronjlarsen/config.h b/keyboards/splitkb/kyria/keymaps/cameronjlarsen/config.h
117index efd8c8fe24dddb5d61b81e3bdf07dff48dd0aa67..bcbdbac9e243cf3fec15a8a8c7913fff4e0071f6 100644
118--- a/keyboards/splitkb/kyria/keymaps/cameronjlarsen/config.h
119+++ b/keyboards/splitkb/kyria/keymaps/cameronjlarsen/config.h
120@@ -33,8 +33,6 @@
121 # define RGBLIGHT_LIMIT_VAL 150
122 #endif
123
124-// Lets you roll mod-tap keys
125-#define IGNORE_MOD_TAP_INTERRUPT
126 // Enable rapid switch from tap to hold, disables double tap hold auto-repeat.
127 #define TAPPING_FORCE_HOLD
128 // Configure the global tapping term (default: 200ms)
129diff --git a/quantum/action_tapping.h b/quantum/action_tapping.h
130index 6099d80d6d05401fe01a595f23cc31e3e2aeed63..6b518b829880c9362f7d5fd429191faa3ba1ec30 100644
131--- a/quantum/action_tapping.h
132+++ b/quantum/action_tapping.h
133@@ -43,7 +43,6 @@ void action_tapping_process(keyrecord_t record);
134 uint16_t get_tapping_term(uint16_t keycode, keyrecord_t *record);
135 uint16_t get_quick_tap_term(uint16_t keycode, keyrecord_t *record);
136 bool get_permissive_hold(uint16_t keycode, keyrecord_t *record);
137-bool get_ignore_mod_tap_interrupt(uint16_t keycode, keyrecord_t *record);
138 bool get_retro_tapping(uint16_t keycode, keyrecord_t *record);
139 bool get_hold_on_other_key_press(uint16_t keycode, keyrecord_t *record);
140